[
https://issues.apache.org/jira/browse/PHOENIX-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873855#comment-17873855
] ASF GitHub Bot commented on PHOENIX-6940: ----------------------------------------- stoty commented on PR #136: URL: https://github.com/apache/phoenix-connectors/pull/136#issuecomment-2290944234 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 10m 51s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 9s | root in master failed. | | -1 :x: | compile | 0m 6s | root in master failed. | | -1 :x: | checkstyle | 0m 31s | The patch fails to run checkstyle in root | | -1 :x: | javadoc | 0m 9s | phoenix5-hive in master failed. | | -1 :x: | javadoc | 0m 7s | root in master failed. | | -1 :x: | javadoc | 0m 15s | phoenix5-connectors-assembly in master failed. | | -1 :x: | javadoc | 0m 12s | phoenix5-hive-shaded in master failed. | | -1 :x: | spotbugs | 0m 9s | phoenix5-hive in master failed. | | -1 :x: | spotbugs | 0m 6s | root in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 3m 30s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 7s | root in the patch failed. | | -1 :x: | compile | 0m 6s | root in the patch failed. | | -1 :x: | javac | 0m 6s | root in the patch failed. | | -1 :x: | checkstyle | 0m 39s | The patch fails to run checkstyle in root | | -1 :x: | whitespace | 0m 0s | The patch has 15 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. | | +1 :green_heart: | xml | 0m 15s | The patch has no ill-formed XML file. | | +1 :green_heart: | yamllint | 0m 1s | There were no new yamllint issues. | | -1 :x: | javadoc | 0m 9s | phoenix5-hive in the patch failed. | | -1 :x: | javadoc | 0m 10s | phoenix5-hive4 in the patch failed. | | -1 :x: | javadoc | 0m 7s | root in the patch failed. | | -1 :x: | javadoc | 0m 11s | phoenix5-connectors-assembly in the patch failed. | | -1 :x: | javadoc | 0m 7s | phoenix5-hive4-shaded in the patch failed. | | -1 :x: | javadoc | 0m 8s | phoenix5-hive-shaded in the patch failed. | | -1 :x: | spotbugs | 0m 9s | phoenix5-hive in the patch failed. | | -1 :x: | spotbugs | 0m 9s | phoenix5-hive4 in the patch failed. | | -1 :x: | spotbugs | 0m 7s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 6s | root in the patch failed. | | -1 :x: | asflicense | 0m 46s | The patch generated 1 ASF License warnings. | | | | 20m 28s | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/136 | | Optional Tests | dupname asflicense yamllint javac javadoc unit xml compile spotbugs hbaseanti checkstyle | | uname | Linux 090db246d74f 5.15.0-113-generic #123-Ubuntu SMP Mon Jun 10 08:16:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / 4c880e2 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/branch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/branch-compile-root.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/buildtool-branch-checkstyle-root.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/branch-javadoc-phoenix5-hive.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/branch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/branch-javadoc-phoenix5-connectors-assembly.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/branch-javadoc-phoenix5-hive-shaded.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-hive.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/branch-spotbugs-root.txt | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-compile-root.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/whitespace-eol.txt | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/whitespace-tabs.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-javadoc-phoenix5-hive.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-javadoc-phoenix5-hive4.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-javadoc-phoenix5-connectors-assembly.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-javadoc-phoenix5-hive4-shaded.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-javadoc-phoenix5-hive-shaded.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-hive.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-hive4.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-spotbugs-root.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/testReport/ | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 52 (vs. ulimit of 30000) | | modules | C: phoenix5-hive phoenix5-hive4 . phoenix5-connectors-assembly phoenix5-hive4-shaded phoenix5-hive-shaded U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-136/6/console | | versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. > Add a connector variant for Hive 4 > ---------------------------------- > > Key: PHOENIX-6940 > URL: https://issues.apache.org/jira/browse/PHOENIX-6940 > Project: Phoenix > Issue Type: New Feature > Components: connectors, hive-connector > Reporter: Istvan Toth > Assignee: Istvan Toth > Priority: Major > > Hive 4 introduces several API changes that are incompatible with Hive 3. > We're going to need add a new connector for Hive 4. > There is no need for a big rewrite like we did for Spark 3, but we will > probably need to duplicate the module. > Hive 4 is not out yet, but we can get a head start targeting the latest alpha > release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
