virajjasani commented on code in PR #1955: URL: https://github.com/apache/phoenix/pull/1955#discussion_r1720904297
########## phoenix-core/src/it/java/org/apache/phoenix/end2end/UpdateCacheFreqWithDDLValidationIT.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.phoenix.end2end; + +import org.apache.phoenix.coprocessorclient.BaseScannerRegionObserverConstants; +import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.thirdparty.com.google.common.collect.Maps; +import org.apache.phoenix.util.ReadOnlyProps; +import org.junit.BeforeClass; + +import java.util.Map; + +//@Category(NeedsOwnMiniClusterTest.class) +// Uncomment as part of PHOENIX-7381 Review Comment: My point is, when we uncomment this test as part of PHOENIX-7381, the tests will likely pass. Until PHOENIX-7381, these tests will not pass because even for 10/20s UCF, they still perform validate ddl timestamp and that makes getTable() call internally, hence the test fails as of now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
