rejeb commented on PR #139: URL: https://github.com/apache/phoenix-connectors/pull/139#issuecomment-2355323138
Hi @stoty, I should've run all tests at once instead of running them individually before submitting the PR. I found out that the failed tests are just duplication because they use `.format(PhoenixTestingDataSource.TEST_SOURCE)` and not V1 and V2 format. However I added reset of the TOTAL_BATCHES_COMMITTED_COUNT before each test. I went on a tricky error tests with tables `DATE_TEST` and `TIME_TEST` because they use currentdatetime and check that date is less than 24 hours difference. I changed these tests to use a fixed date. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
