stoty commented on code in PR #1994:
URL: https://github.com/apache/phoenix/pull/1994#discussion_r1797706963
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/InstanceResolver.java:
##########
@@ -71,14 +70,22 @@ public static <T> T getSingleton(Class<T> clazz, T
defaultInstance) {
public static <T> List get(Class<T> clazz, List<T> defaultInstances) {
Iterator<T> iterator = ServiceLoader.load(clazz).iterator();
if (defaultInstances != null) {
- defaultInstances.addAll(IteratorUtils.toList(iterator));
+ defaultInstances.addAll(iteratorToList(iterator));
} else {
- defaultInstances = IteratorUtils.toList(iterator);
+ defaultInstances = iteratorToList(iterator);
}
return defaultInstances;
}
+ private static <T> List<T> iteratorToList(Iterator<T> iterator) {
Review Comment:
I mean the guava or lambd based ones.
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/InstanceResolver.java:
##########
@@ -71,14 +70,22 @@ public static <T> T getSingleton(Class<T> clazz, T
defaultInstance) {
public static <T> List get(Class<T> clazz, List<T> defaultInstances) {
Iterator<T> iterator = ServiceLoader.load(clazz).iterator();
if (defaultInstances != null) {
- defaultInstances.addAll(IteratorUtils.toList(iterator));
+ defaultInstances.addAll(iteratorToList(iterator));
} else {
- defaultInstances = IteratorUtils.toList(iterator);
+ defaultInstances = iteratorToList(iterator);
}
return defaultInstances;
}
+ private static <T> List<T> iteratorToList(Iterator<T> iterator) {
Review Comment:
nit: While there is nothing wrong with this, here are a few solutions that
do not need a new method:
https://stackoverflow.com/questions/10117026/convert-iterator-to-list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
