[
https://issues.apache.org/jira/browse/PHOENIX-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889174#comment-17889174
]
ASF GitHub Bot commented on PHOENIX-7430:
-----------------------------------------
NihalJain commented on code in PR #163:
URL:
https://github.com/apache/phoenix-queryserver/pull/163#discussion_r1799256908
##########
phoenix-queryserver/src/main/java/org/apache/phoenix/util/InstanceResolver.java:
##########
@@ -68,10 +67,13 @@ public static <T> T getSingleton(Class<T> clazz, T
defaultInstance) {
@SuppressWarnings("unchecked")
public static <T> List get(Class<T> clazz, List<T> defaultInstances) {
Iterator<T> iterator = ServiceLoader.load(clazz).iterator();
+ List<T> instances = new ArrayList<>();
Review Comment:
There is no guava in PQS, so had to do this inplace using lambdas. Should we
sync same logic in Phoenix? This class seems to be present at both places.
> Remove commons-collections dependency in queryserver
> ----------------------------------------------------
>
> Key: PHOENIX-7430
> URL: https://issues.apache.org/jira/browse/PHOENIX-7430
> Project: Phoenix
> Issue Type: Task
> Components: queryserver
> Reporter: Nihal Jain
> Assignee: Nihal Jain
> Priority: Major
>
> Apache Phoenix QueryServer currently uses {{commons-collections}} (3.2.2),
> which is End-of-Life (EOL) with no new updates since November 2015. Upgrading
> to {{commons-collections4}} will ensure continued support, security patches,
> and new features. It's prudent to phase out its use within Apache Phoenix for
> better maintenance and security. Alternately we will remove the dependency,
> if it is not being used extensively in the project.
> CC: [~stoty]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
