stoty commented on code in PR #163:
URL:
https://github.com/apache/phoenix-queryserver/pull/163#discussion_r1800626088
##########
phoenix-queryserver/src/main/java/org/apache/phoenix/util/InstanceResolver.java:
##########
@@ -68,10 +67,13 @@ public static <T> T getSingleton(Class<T> clazz, T
defaultInstance) {
@SuppressWarnings("unchecked")
public static <T> List get(Class<T> clazz, List<T> defaultInstances) {
Iterator<T> iterator = ServiceLoader.load(clazz).iterator();
+ List<T> instances = new ArrayList<>();
Review Comment:
Lambdas are fine.
It's such a simple thing that I don't think syncing the implementation is
worth the effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
