NihalJain commented on code in PR #170:
URL: https://github.com/apache/phoenix-omid/pull/170#discussion_r1801631351


##########
common/src/main/proto/TSOProto.proto:
##########
@@ -16,51 +16,51 @@
 // limitations under the License.
 //
 
+syntax = "proto3";

Review Comment:
   any reason for building with proto3? hbase still uses proto2 even though 
builds with proto 4.8.2?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to