tkhurana commented on code in PR #2013: URL: https://github.com/apache/phoenix/pull/2013#discussion_r1807030731
########## phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/BlockBytesScannedMetricIT.java: ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.regionserver; + +import java.io.IOException; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.Map; + +import org.apache.hadoop.hbase.TableName; +import org.apache.phoenix.end2end.NeedsOwnMiniClusterTest; +import org.apache.phoenix.jdbc.PhoenixResultSet; +import org.apache.phoenix.jdbc.PhoenixStatement; +import org.apache.phoenix.monitoring.MetricType; +import org.apache.phoenix.query.BaseTest; +import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.thirdparty.com.google.common.collect.Maps; +import org.apache.phoenix.util.PhoenixRuntime; +import org.apache.phoenix.util.ReadOnlyProps; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +@Category(NeedsOwnMiniClusterTest.class) +public class BlockBytesScannedMetricIT extends BaseTest { + + @BeforeClass + public static synchronized void doSetup() throws Exception { + Map<String, String> props = Maps.newHashMapWithExpectedSize(2); + props.put(QueryServices.COLLECT_REQUEST_LEVEL_METRICS, "true"); + setUpTestDriver(new ReadOnlyProps(props)); + } + + @Test + public void testPointLookupBlockBytesScannedMetric() throws Exception { + Connection conn = DriverManager.getConnection(getUrl()); + String tableName = generateUniqueName(); + PhoenixStatement stmt = conn.createStatement().unwrap(PhoenixStatement.class); + stmt.execute("CREATE TABLE " + tableName + + " (A UNSIGNED_LONG NOT NULL PRIMARY KEY, Z UNSIGNED_LONG)"); + for (int i = 1; i <= 10; i++) { + String sql = String.format("UPSERT INTO %s VALUES (%d, %d)", tableName, i, i); + stmt.execute(sql); + } + conn.commit(); + + String POINT_LOOKUP_QUERY = "SELECT * FROM " + tableName + " WHERE A = 9"; + + // read from memory, block bytes read should be 0 + long count0 = countBlockBytesScannedFromSql(stmt, POINT_LOOKUP_QUERY); + Assert.assertTrue(count0 == 0); + + // flush and clear block cache + flush(tableName); + clearBlockCache(tableName); + + long count1 = countBlockBytesScannedFromSql(stmt, POINT_LOOKUP_QUERY); + Assert.assertTrue(count1 > 0); + } + + @Test + public void testRangeScanBlockBytesScannedMetric() throws Exception { + Connection conn = DriverManager.getConnection(getUrl()); + String tableName = generateUniqueName(); + PhoenixStatement stmt = conn.createStatement().unwrap(PhoenixStatement.class); + // create table with small block size and upsert enough rows to have at least 2 blocks + stmt.execute("CREATE TABLE " + tableName + + " (A UNSIGNED_LONG NOT NULL PRIMARY KEY, Z UNSIGNED_LONG) BLOCKSIZE=200"); + for (int i = 1; i <= 20; i++) { + String sql = String.format("UPSERT INTO %s VALUES (%d, %d)", tableName, i, i); + stmt.execute(sql); + } + conn.commit(); + flush(tableName); + clearBlockCache(tableName); + + String RANGE_SCAN_QUERY = "SELECT * FROM " + tableName + " WHERE A > 14 AND A < 18"; + String SERVER_FILTER_QUERY = "SELECT * FROM " + tableName + " WHERE Z > 14 AND Z < 18"; + String SELECT_ALL_QUERY = "SELECT * FROM " + tableName; + + long count1 = countBlockBytesScannedFromSql(stmt, RANGE_SCAN_QUERY); + Assert.assertTrue(count1 > 0); + + long count2 = countBlockBytesScannedFromSql(stmt, SERVER_FILTER_QUERY); + Assert.assertTrue(count2 > 0); + // where clause has non PK column, will have to scan all rows + Assert.assertTrue(count2 > count1); + + long count3 = countBlockBytesScannedFromSql(stmt, SELECT_ALL_QUERY); + Assert.assertTrue(count3 > 0); + // should be same as previous query which also scans all rows + Assert.assertEquals(count3, count2); + } + + private void clearBlockCache(String tableName) { + HRegionServer regionServer = utility.getMiniHBaseCluster().getRegionServer(0); + for (HRegion region : regionServer.getRegions(TableName.valueOf(tableName))) { + regionServer.clearRegionBlockCache(region); + } + } + + private void flush(String tableName) throws IOException { Review Comment: I think we already have a utility flush method in TestUtil class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
