kadirozde commented on code in PR #2030:
URL: https://github.com/apache/phoenix/pull/2030#discussion_r1861731138
##########
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -1167,19 +1173,29 @@ private static void
identifyIndexMaintainerTypes(PhoenixIndexMetaData indexMetaD
}
private void identifyMutationTypes(MiniBatchOperationInProgress<Mutation>
miniBatchOp,
- BatchMutateContext context) {
+ BatchMutateContext context)
throws IOException {
for (int i = 0; i < miniBatchOp.size(); i++) {
Mutation m = miniBatchOp.getOperation(i);
if (this.builder.returnResult(m) && miniBatchOp.size() == 1) {
context.returnResult = true;
}
if (this.builder.isAtomicOp(m) || this.builder.returnResult(m)) {
context.hasAtomic = true;
- if (context.hasDelete) {
+ if (context.hasRowDelete) {
return;
}
} else if (m instanceof Delete) {
- context.hasDelete = true;
+ CellScanner scanner = m.cellScanner();
+ if (m.isEmpty()) {
+ context.hasRowDelete = true;
+ } else {
+ while (scanner.advance()) {
+ if (scanner.current().getType() ==
Cell.Type.DeleteFamily) {
+ context.hasRowDelete = true;
Review Comment:
If delete mutations are for deleting columns, then hasRowDelete will be
false. These mutations are used when the column values are set to null using
upsert statements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
