palashc commented on code in PR #2051: URL: https://github.com/apache/phoenix/pull/2051#discussion_r1904694251
########## phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/PhoenixMasterObserver.java: ########## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.coprocessor; + +import java.sql.Connection; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Types; +import java.util.Arrays; +import java.util.Optional; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.coprocessor.MasterCoprocessor; +import org.apache.hadoop.hbase.coprocessor.MasterCoprocessorEnvironment; +import org.apache.hadoop.hbase.coprocessor.MasterObserver; +import org.apache.hadoop.hbase.coprocessor.ObserverContext; +import org.apache.hadoop.hbase.client.RegionInfo; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.phoenix.schema.PTable; +import org.apache.phoenix.schema.TableNotFoundException; +import org.apache.phoenix.util.CDCUtil; +import org.apache.phoenix.util.PhoenixRuntime; +import org.apache.phoenix.util.QueryUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_CDC_STREAM_NAME; +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_CDC_STREAM_STATUS_NAME; + +/** + * Master Coprocessor for Phoenix. + */ +public class PhoenixMasterObserver implements MasterObserver, MasterCoprocessor { + private static final Logger LOGGER = LoggerFactory.getLogger(PhoenixMasterObserver.class); + + private static final String STREAM_STATUS_QUERY + = "SELECT STREAM_NAME FROM " + SYSTEM_CDC_STREAM_STATUS_NAME + + " WHERE TABLE_NAME = ? AND STREAM_STATUS='" + + CDCUtil.CdcStreamStatus.ENABLED.getSerializedValue() + "'"; + + // tableName, streamName, partitionId, parentId, startTime, endTime, startKey, endKey + private static final String PARTITION_UPSERT_SQL + = "UPSERT INTO " + SYSTEM_CDC_STREAM_NAME + " VALUES (?,?,?,?,?,?,?,?)"; + + private static final String PARENT_PARTITION_QUERY + = "SELECT PARTITION_ID FROM " + SYSTEM_CDC_STREAM_NAME + + " WHERE TABLE_NAME = ? AND STREAM_NAME = ? "; + + private static final String PARENT_PARTITION_UPDATE_END_TIME_SQL + = "UPSERT INTO " + SYSTEM_CDC_STREAM_NAME + " (TABLE_NAME, STREAM_NAME, PARTITION_ID, " + + "PARTITION_END_TIME) VALUES (?,?,?,?)"; + + @Override + public Optional<MasterObserver> getMasterObserver() { + return Optional.of(this); + } + + /** + * Update parent -> daughter relationship for CDC Streams. + * - find parent partition id using start/end keys of daughters + * - upsert partition metadata for the 2 daughters + * - update the end time on the parent's partition metadata + * @param c the environment to interact with the framework and master + * @param regionInfoA the left daughter region + * @param regionInfoB the right daughter region + */ + @Override + public void postCompletedSplitRegionAction(final ObserverContext<MasterCoprocessorEnvironment> c, + final RegionInfo regionInfoA, final RegionInfo regionInfoB) { + Configuration conf = c.getEnvironment().getConfiguration(); + try { + Connection conn = QueryUtil.getConnectionOnServer(conf); + // CDC will be enabled on Phoenix tables only + PTable phoenixTable = getPhoenixTable(conn, regionInfoA.getTable()); + if (phoenixTable == null) { + LOGGER.info(regionInfoA.getTable() + " is not a Phoenix Table, " + + "skipping partition metadata update."); + return; + } + // find streamName with ENABLED status + String tableName = phoenixTable.getName().getString(); + PreparedStatement pstmt = conn.prepareStatement(STREAM_STATUS_QUERY); + pstmt.setString(1, tableName); + ResultSet rs = pstmt.executeQuery(); + if (rs.next()) { + String streamName = rs.getString(1); + LOGGER.info("Updating partition metadata for table=" + tableName + ", stream=" + + streamName + " for daughters " + regionInfoA.getEncodedName() + " " + + regionInfoB.getEncodedName()); + String parentPartitionID = getParentPartitionId(conn, tableName, streamName, regionInfoA, regionInfoB); + upsertDaughterPartition(conn, tableName, streamName, parentPartitionID, regionInfoA); + upsertDaughterPartition(conn, tableName, streamName, parentPartitionID, regionInfoB); + updateParentPartitionEndTime(conn, tableName, streamName, parentPartitionID, regionInfoA.getRegionId()); + } + } catch (SQLException e) { + LOGGER.error("Unable to update CDC Stream Partition metadata during split with daughter regions: " + + regionInfoA.getEncodedName() + " " + regionInfoB.getEncodedName() ); + LOGGER.error("Error: " + e); Review Comment: done ########## phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/tasks/CdcStreamPartitionMetadataTask.java: ########## @@ -136,13 +136,16 @@ private void upsertPartitionMetadata(PhoenixConnection pconn, String tableName, throws SQLException { try (PreparedStatement ps = pconn.prepareStatement(CDC_STREAM_PARTITION_UPSERT_SQL)) { for (HRegionLocation tableRegion : tableRegions) { + // set parent_partition_id, partition_end_time to null RegionInfo ri = tableRegion.getRegionInfo(); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
