haridsv commented on code in PR #2054: URL: https://github.com/apache/phoenix/pull/2054#discussion_r1916058202
########## phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixPrefetchedResultSet.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.phoenix.jdbc; + +import java.sql.SQLException; +import java.util.List; + +import org.apache.phoenix.compile.RowProjector; +import org.apache.phoenix.compile.StatementContext; +import org.apache.phoenix.schema.tuple.Tuple; + +/** + * Phoenix ResultSet implementation with prefetched rows. It is expected that the implementation + * does not need to use any iterators to make server side RPC call. + */ +public class PhoenixPrefetchedResultSet extends PhoenixResultSet { + + private final List<Tuple> prefetchedRows; + private int prefetchedRowsIndex; + + public PhoenixPrefetchedResultSet(RowProjector rowProjector, + StatementContext ctx, List<Tuple> prefetchedRows) throws SQLException { + super(null, rowProjector, ctx); + this.prefetchedRows = prefetchedRows; + this.prefetchedRowsIndex = 0; + } + + @Override + protected Tuple getCurrentRowImpl() { + return prefetchedRows.get(prefetchedRowsIndex++); Review Comment: When a row is deleted, there will only be a single row returned correct? Is there a scenario in which the size of `prefetchedRows` is more than 1? In any case, JDBC contract for `next()` is to return a `false` when there are no more rows, but looking at the implementation of `getCurrentRow` in the base class, it looks like user wlll see an `IndexOutOfBoundsException`? We would also need test coverage for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
