[
https://issues.apache.org/jira/browse/PHOENIX-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916289#comment-17916289
]
Istvan Toth edited comment on PHOENIX-5215 at 1/23/25 6:40 AM:
---------------------------------------------------------------
I was trying to make opentelemetry actually useful in Phoenix, which has opened
a very big can of worms.
I would suggest concentrating on removing htrace, and not worrying about
whether the new tracing does anything useful (as long as it doesn't leak
resources or similar).
There are also current features like being able to control tracing via SQL, and
pushing the trace to a table, which are very hard to do with opentelemetry, I
suggest simply dropping/disabling those features.
I'd suggest either doing a minimum effort opentelementry refactor, or using /
copying the noop htrace implementation from HBase as a first step.
Once we're htrace free, we can work on making opentelemetry actually useful,
and adding (back) features.
was (Author: stoty):
I was trying to make opentelemetry actually useful in Phoenix, has opened a
very big can of worms.
I would suggest concentrating on removing htrace, and not worrying about
whether the new tracing does anything useful (as long as it doesn't leak
resources or similar).
There are also current features like being able to control tracing via SQL, and
pushing the trace to a table, which are very hard to do with opentelemetry, I
suggest simply dropping/disabling those features.
I'd suggest either doing a minimum effort opentelementry refactor, or using /
copying the noop htrace implementation from HBase as a first step.
Once we're htrace free, we can work on making opentelemetry actually useful,
and adding (back) features.
> Remove and replace HTrace
> -------------------------
>
> Key: PHOENIX-5215
> URL: https://issues.apache.org/jira/browse/PHOENIX-5215
> Project: Phoenix
> Issue Type: Bug
> Reporter: Andrew Kyle Purtell
> Priority: Major
> Fix For: 5.3.0
>
>
> HTrace is dead.
> Hadoop is discussing a replacement of HTrace with OpenTracing, see
> HADOOP-15566
> HBase is having the same discussion on HBASE-22120
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
