stoty commented on code in PR #2056:
URL: https://github.com/apache/phoenix/pull/2056#discussion_r1961544521
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionIT.java:
##########
@@ -58,6 +59,7 @@ public static synchronized void setUp() throws Exception {
conf = hbaseTestUtil.getConfiguration();
setUpConfigForMiniCluster(conf);
conf.set(HConstants.ZOOKEEPER_ZNODE_PARENT, "/hbase-test");
+ conf.set("hbase.client.registry.impl",
ZKConnectionInfo.ZK_REGISTRY_NAME);
Review Comment:
We only need to suppor up to 2.4.0, and that one has
CLIENT_CONNECTION_REGISTRY_IMPL_CONF_KEY, so better use that.
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpdateCacheAcrossDifferentClientsIT.java:
##########
@@ -71,6 +72,8 @@ public void testUpdateCacheFrequencyWithAddAndDropTable()
throws Exception {
longRunningProps.put(QueryServices.EXTRA_JDBC_ARGUMENTS_ATTRIB,
QueryServicesOptions.DEFAULT_EXTRA_JDBC_ARGUMENTS);
longRunningProps.put(QueryServices.DROP_METADATA_ATTRIB,
Boolean.TRUE.toString());
+ longRunningProps.put("hbase.client.registry.impl",
ZKConnectionInfo.ZK_REGISTRY_NAME);
Review Comment:
The same apples to all "hbase.client.registry.impl" strings, we use
HConstants instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
