palashc commented on code in PR #2075:
URL: https://github.com/apache/phoenix/pull/2075#discussion_r1985768919
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/PhoenixRegionServerEndpoint.java:
##########
@@ -61,7 +61,17 @@ public void validateLastDDLTimestamp(RpcController
controller,
RegionServerEndpointProtos.ValidateLastDDLTimestampRequest request,
RpcCallback<RegionServerEndpointProtos.ValidateLastDDLTimestampResponse> done) {
metricsSource.incrementValidateTimestampRequestCount();
- ServerMetadataCache cache = getServerMetadataCache();
+ ServerMetadataCache cache;
+ try {
+ cache = getServerMetadataCache();
Review Comment:
With this feature, under what conditions can the creation of the server
metadata cache fail? When this feature is enabled, do we need to take any
server side action in the case of that failure? Should we block mutations in
that case - if yes, how can we achieve that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
