stoty commented on code in PR #2096:
URL: https://github.com/apache/phoenix/pull/2096#discussion_r2012162408
##########
bin/phoenix_utils.py:
##########
@@ -221,8 +221,11 @@ def shell_quote(args):
return subprocess.list2cmdline(args)
else:
# pipes module isn't available on Windows
- import pipes
- return " ".join([pipes.quote(tryDecode(v)) for v in args])
+ try:
Review Comment:
actually, cmd_quote is also fine, but it would be nice to have it together
at the start of the file.
##########
bin/phoenix_utils.py:
##########
@@ -221,8 +221,11 @@ def shell_quote(args):
return subprocess.list2cmdline(args)
else:
# pipes module isn't available on Windows
- import pipes
- return " ".join([pipes.quote(tryDecode(v)) for v in args])
+ try:
Review Comment:
actually, cmd_quote is also fine, but it would be nice to have these
together at the start of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
