jpisaac commented on code in PR #2075:
URL: https://github.com/apache/phoenix/pull/2075#discussion_r2017291795
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -1055,4 +1057,20 @@ public void
preClose(ObserverContext<RegionCoprocessorEnvironment> c, boolean ab
protected boolean isRegionObserverFor(Scan scan) {
return
scan.getAttribute(BaseScannerRegionObserverConstants.UNGROUPED_AGG) != null;
}
+
+ @Override
+ public void preBatchMutate(ObserverContext<RegionCoprocessorEnvironment> c,
Review Comment:
@ujjawal4046 @palashc Just to add to @ritegarg comments -
All mutations will be intercepted and handled thru IndexRegionObserver and
henceforth IndexRegionObserver will be enabled for all Phoenix tables (being
mandated as a prerequisite).
PHOENIX-7107 will added indexes to SYSCAT, And will create a separate JIRA
for enabling it on other SYSTEM tables.
Mutations on Index tables need not be blocked since those need not be
replicated.
HBase tables will need to be converted to Phoenix tables, if this feature is
to be effective.
Adding it to UngroupedAggregateRegionObserver in the interim.
Let us know if you see concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
