jpisaac commented on code in PR #2138:
URL: https://github.com/apache/phoenix/pull/2138#discussion_r2073813866
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -451,11 +459,13 @@ private PMetaData newEmptyMetaData() {
/**
* Construct a ConnectionQueryServicesImpl that represents a connection to
an HBase
* cluster.
- * @param services base services from where we derive our default
configuration
- * @param connectionInfo to provide connection information
- * @param info hbase configuration properties
+ *
+ * @param services base services from where we derive our default
configuration
+ * @param connectionInfo to provide connection information
+ * @param info hbase configuration properties
+ * @param additionalConfig additionalConfig to be added to existing config
*/
- public ConnectionQueryServicesImpl(QueryServices services, ConnectionInfo
connectionInfo, Properties info) {
+ public ConnectionQueryServicesImpl(QueryServices services, ConnectionInfo
connectionInfo, Properties info, Configuration additionalConfig) {
Review Comment:
Let's not add any new parameters to the constructor for additional
configuration object. Configuration objects should only be created by calling
ConfigurationFactory as below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
