sanjeet006py commented on PR #2148: URL: https://github.com/apache/phoenix/pull/2148#issuecomment-2887261051
> we realized that the test case is not written correctly. You are inserting multiple rows in a batch which means HBase will assign the same timestamp for all these cells. When querying for these rows, Phoenix will see the same timestamp for all the rows and so there is no way to reproduce the order in which the rows were added to the batch. @haridsv I think this will be a problem when we will be using `UpsertingParallelIteratorFactory` but if upsert select is running purely on client side without using parallel iterators then latter row fetched from server to client will override the former row with same row key already present in `MultiRowMutationState`. So, I think the fix done by @chaijunjie0101 handles that case as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org