ritegarg commented on code in PR #2173:
URL: https://github.com/apache/phoenix/pull/2173#discussion_r2127167655


##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HighAvailabilityPolicy.java:
##########
@@ -161,12 +164,7 @@ private void transitStandby(HighAvailabilityGroup haGroup, 
String url,
         private void transitActive(HighAvailabilityGroup haGroup, String url,
                                    ClusterRoleRecord.RegistryType 
registryType) throws SQLException {
             // Invalidate CQS cache if any that has been closed but has not 
been cleared
-                for (HAURLInfo haurlInfo : 
HighAvailabilityGroup.URLS.get(haGroup.getGroupInfo())) {

Review Comment:
   For line 161 -> If we change standby from cluster1 to cluster2, close the 
connection but not invalidate the cache. If we rollback, will we observe 
connection closed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to