lokiore commented on code in PR #2174:
URL: https://github.com/apache/phoenix/pull/2174#discussion_r2136604355
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HighAvailabilityPolicy.java:
##########
@@ -75,20 +75,20 @@ void transitClusterRole(HighAvailabilityGroup haGroup,
ClusterRoleRecord oldReco
"Doing nothing for Cluster Role Change");
return;
}
- if ((oldRecord.getRole1() == ACTIVE || oldRecord.getRole1() ==
ACTIVE_TO_STANDBY)
- && newRecord.getRole1() == STANDBY) {
- transitStandby(haGroup, oldRecord.getUrl1(),
oldRecord.getRegistryType());
+ if (oldRecord.getRole1() == ACTIVE &&
+ (newRecord.getRole1() == STANDBY || newRecord.getRole1()
== ACTIVE_TO_STANDBY)) {
Review Comment:
@shahrs87 we need to detect a change right? otherwise we could just close
connections if there is only a version change or one role can affect the other
role..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
