virajjasani commented on code in PR #2191:
URL: https://github.com/apache/phoenix/pull/2191#discussion_r2144075842


##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/PhoenixMasterObserver.java:
##########
@@ -74,11 +82,19 @@ public class PhoenixMasterObserver implements 
MasterObserver, MasterCoprocessor
             = "UPSERT INTO " + SYSTEM_CDC_STREAM_NAME + " (TABLE_NAME, 
STREAM_NAME, PARTITION_ID, "
             + "PARENT_PARTITION_ID, PARTITION_END_TIME) VALUES (?,?,?,?,?)";
 
+    private static final int MAX_RETRY_COUNT = 20;

Review Comment:
   We could but probably good to avoid config here. I verified that HBase will 
also retry when coproc throws IOE here anyways.
   20 or 40, eventually we need some retries here, otherwise error will anyways 
trigger Split/Merge procedures to retry.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to