virajjasani commented on PR #2195: URL: https://github.com/apache/phoenix/pull/2195#issuecomment-2982739075
I just realized the findbugs warning might be worth fixing: ``` org.apache.phoenix.coprocessor.PhoenixMasterObserver.getAncestorIdsForSplit(Connection, String, String, RegionInfo, RegionInfo) may fail to clean up java.sql.ResultSet Obligation to clean up resource created at PhoenixMasterObserver.java:may fail to clean up java.sql.ResultSet Obligation to clean up resource created at PhoenixMasterObserver.java:[line 288] is not discharged -- | org.apache.phoenix.coprocessor.PhoenixMasterObserver.getAncestorIdsForSplit(Connection, String, String, RegionInfo, RegionInfo) may fail to clean up java.sql.Statement Obligation to clean up resource created at PhoenixMasterObserver.java:may fail to clean up java.sql.Statement Obligation to clean up resource created at PhoenixMasterObserver.java:[line 279] is not discharged | org.apache.phoenix.coprocessor.PhoenixMasterObserver.upsertDaughterPartitions(Connection, String, String, List, List, List) may fail to clean up java.sql.Statement Obligation to clean up resource created at PhoenixMasterObserver.java:List) may fail to clean up java.sql.Statement Obligation to clean up resource created at PhoenixMasterObserver.java:[line 349] is not discharged ``` Since we create multiple (two) ResultSet objects on the same Connection, it would be better to wrap the ResultSet with try-with-resources as an addendum PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
