ritegarg commented on code in PR #2198:
URL: https://github.com/apache/phoenix/pull/2198#discussion_r2162509524


##########
phoenix-core/src/it/java/org/apache/phoenix/jdbc/ParallelPhoenixConnectionIT.java:
##########
@@ -250,6 +257,48 @@ public void testCluster1OfflineRole() throws Exception {
         }
     }
 
+    /**
+     * Test Phoenix connection creation and basic operations with HBase both 
cluster is ACTIVE_TO_STANDBY role.
+     */
+    @Test
+    public void bothClusterATSRole() throws Exception {
+        CLUSTERS.transitClusterRole(haGroup, ClusterRole.ACTIVE_TO_STANDBY, 
ClusterRole.ACTIVE_TO_STANDBY);
+        try (Connection conn = getParallelConnection()) {
+            doTestBasicOperationsWithConnection(conn, tableName, haGroupName);
+        } catch (SQLException e) {

Review Comment:
   This is part of client code which is not under test. Removed these tests for 
now as per our discussion



##########
phoenix-core/src/it/java/org/apache/phoenix/jdbc/ParallelPhoenixConnectionIT.java:
##########
@@ -250,6 +257,48 @@ public void testCluster1OfflineRole() throws Exception {
         }
     }
 
+    /**
+     * Test Phoenix connection creation and basic operations with HBase both 
cluster is ACTIVE_TO_STANDBY role.
+     */
+    @Test
+    public void bothClusterATSRole() throws Exception {
+        CLUSTERS.transitClusterRole(haGroup, ClusterRole.ACTIVE_TO_STANDBY, 
ClusterRole.ACTIVE_TO_STANDBY);
+        try (Connection conn = getParallelConnection()) {
+            doTestBasicOperationsWithConnection(conn, tableName, haGroupName);
+        } catch (SQLException e) {
+            assertTrue(containsMutationBlockedException(e));
+        }
+    }
+
+    /**
+     * Test Phoenix connection creation and basic operations with HBase one 
cluster is ACTIVE_TO_STANDBY role.
+     */
+    @Test
+    public void oneClusterATSRole() throws Exception {
+        CLUSTERS.transitClusterRole(haGroup, ClusterRole.ACTIVE_TO_STANDBY, 
ClusterRole.ACTIVE);
+        int countExceptions = 0;
+        try (Connection conn = getParallelConnection()) {
+            doTestBasicOperationsWithConnection(conn, tableName, haGroupName);
+        } catch (SQLException e) {

Review Comment:
   Same as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to