virajjasani commented on code in PR #2230:
URL: https://github.com/apache/phoenix/pull/2230#discussion_r2213984960


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCStreamIT.java:
##########
@@ -95,6 +99,146 @@ public static synchronized void doSetup() throws Exception {
                         
.findCoprocessorEnvironment(TaskRegionObserver.class.getName());
     }
 
+    /**
+     * Test to verify CDC events with index/table level maxLookback and TTL.
+     */
+    @Test
+    public void testCdcWithMaxLookbackAndCompaction() throws Exception {
+        Connection conn = newConnection();
+        String tableName = generateUniqueName();
+        String cdcName = generateUniqueName();
+        String cdcDdl = "CREATE CDC " + cdcName + " ON " + tableName;
+        // maxLookback 27 hr
+        conn.createStatement().execute(

Review Comment:
   We don't have sync for them, which is gap. But for maxLookback, let me add 
the sync during ALTER TABLE also, good point!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to