NihalJain commented on PR #2119: URL: https://github.com/apache/phoenix/pull/2119#issuecomment-3089617991
Weird that previous commit did not fix spotless issue in 2 file, so had to put in https://github.com/apache/phoenix/pull/2119/commits/73a3b99e46e8d4cd2ea4c142546007bb2ce5004f (will raise this as addendum. Good thing we are able to verify spotless fails if issue on branch/patch (if expected) - https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2119/3/artifact/yetus-general-check/output/branch-spotless.txt : Fail, as expected - https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2119/3/artifact/yetus-general-check/output/patch-spotless.txt : Fail, as expected And does not once we fix issues: - https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2119/4/execution/node/3/ws/yetus-general-check/output/branch-spotless.txt : Fail, as expected - https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2119/4/execution/node/3/ws/yetus-general-check/output/patch-spotless.txt : Pass, as expected, since we fixed issue here! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
