NihalJain commented on code in PR #2240:
URL: https://github.com/apache/phoenix/pull/2240#discussion_r2219566999
##########
src/main/config/checkstyle/checker.xml:
##########
@@ -71,109 +71,111 @@ limitations under the License.
<!-- Checks for blocks. You know, those {}'s -->
<!-- See http://checkstyle.sf.net/config_blocks.html -->
- <!-- No empty blocks (i.e. catch); must contain at least a comment -->
+ <!-- No empty blocks (i.e. catch); must contain at least a comment -->
<module name="EmptyBlock">
<property name="option" value="text"/>
</module>
<module name="AvoidNestedBlocks">
- <property name="allowInSwitchCase" value="true"/>
+ <property name="allowInSwitchCase" value="true"/>
</module>
<module name="LeftCurly"/>
- <!-- No if/else/do/for/while without braces -->
+ <!-- No if/else/do/for/while without braces -->
<module name="NeedBraces"/>
<module name="RightCurly"/>
<!-- Checks for class design -->
<!-- See http://checkstyle.sf.net/config_design.html -->
- <!-- Utility class should not be instantiated, they must have a
- private constructor -->
+ <!-- Utility class should not be instantiated, they must have a
+ private constructor -->
<module name="HideUtilityClassConstructor"/>
<!-- Checks for common coding problems -->
<!-- See http://checkstyle.sf.net/config_coding.html -->
<module name="EmptyStatement"/>
- <!-- Require hash code override when equals is -->
+ <!-- Require hash code override when equals is -->
<module name="EqualsHashCode"/>
- <!-- Disallow unnecessary instantiation of Boolean, String -->
+ <!-- Disallow unnecessary instantiation of Boolean, String -->
<module name="IllegalInstantiation">
<property name="classes" value="java.lang.Boolean, java.lang.String"/>
</module>
- <!-- Switch statements should be complete and with independent cases -->
+ <!-- Switch statements should be complete and with independent cases -->
<module name="FallThrough"/>
<module name="SimplifyBooleanExpression"/>
<module name="SimplifyBooleanReturn"/>
- <!-- Only one statement per line allowed -->
+ <!-- Only one statement per line allowed -->
<module name="OneStatementPerLine"/>
- <!-- Don't add up parentheses when they are not required -->
+ <!-- Don't add up parentheses when they are not required -->
<module name="UnnecessaryParentheses" />
- <!-- Don't use = or != for string comparisons -->
+ <!-- Don't use = or != for string comparisons -->
<module name="StringLiteralEquality" />
- <!-- Don't declare multiple variables in the same statement -->
+ <!-- Don't declare multiple variables in the same statement -->
<module name="MultipleVariableDeclarations" />
- <!-- String literals more than one character long should not be
- repeated several times -->
- <!-- the "unchecked" string is also accepted to allow
- @SuppressWarnings("unchecked") -->
- <!-- Disabling for now until we have a better ignoreStringsRegexp -->
- <!--
- <module name="MultipleStringLiterals" >
- <property name="ignoreStringsRegexp"
value='^(("")|(".")|("unchecked"))$'/>
- </module>
- -->
+ <!-- String literals more than one character long should not be
+ repeated several times -->
+ <!-- the "unchecked" string is also accepted to allow
+ @SuppressWarnings("unchecked") -->
+ <!-- Disabling for now until we have a better ignoreStringsRegexp -->
+ <!--
+ <module name="MultipleStringLiterals" >
+ <property name="ignoreStringsRegexp" value='^(("")|(".")|("unchecked"))$'/>
+ </module>
+ -->
<!-- Checks for imports -->
<!-- See http://checkstyle.sf.net/config_import.html -->
<module name="RedundantImport"/>
- <!-- Import should be explicit, and only from pure java packages.
- But we allow imports that are only used in javadoc. -->
+ <!-- Import should be explicit, and only from pure java packages.
+ But we allow imports that are only used in javadoc. -->
<module name="UnusedImports">
<property name="processJavadoc" value="true"/>
</module>
<module name="IllegalImport" />
<module name="AvoidStarImport" />
<module name="ImportOrder">
- <property name="groups"
value="java,javax,lib,shared,common,platform,org,com,io,net,scala,clover"/>
+ <property name="groups"
value="*,org.apache.phoenix.thirdparty,org.apache.phoenix.shaded,org.apache.hbase.thirdparty,org.apache.hadoop.hbase.shaded"/>
Review Comment:
Change 1: Sync ImportOrder groups based on dev/phoenix.importorder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
