haridsv commented on PR #2226: URL: https://github.com/apache/phoenix/pull/2226#issuecomment-3182395441
This: > new org.apache.phoenix.parse.UpsertStatement(NamedTableNode, HintNode, List, List, SelectStatement, int, Map, List, UpsertStatement$OnDuplicateKeyType, boolean) may expose internal representation by storing an externally mutable object into UpsertStatement.onDupKeyPairs > -- > | Bug type EI_EXPOSE_REP2 (click for details)In class org.apache.phoenix.parse.UpsertStatementIn method new org.apache.phoenix.parse.UpsertStatement(NamedTableNode, HintNode, List, List, SelectStatement, int, Map, List, UpsertStatement$OnDuplicateKeyType, boolean)Field org.apache.phoenix.parse.UpsertStatement.onDupKeyPairsLocal variable named onDupKeyPairsAt UpsertStatement.java:[line 51] > > new org.apache.phoenix.parse.UpsertStatement(NamedTableNode, HintNode, List, List, SelectStatement, int, Map, List, UpsertStatement$OnDuplicateKeyType, boolean) may expose internal representation by storing an externally mutable object into UpsertStatement.onDupKeyPairs > [Bug type EI_EXPOSE_REP2 (click for details)](https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2226/10/artifact/yetus-general-check/output/new-spotbugs-phoenix-core-client.html#EI_EXPOSE_REP2) > In class org.apache.phoenix.parse.UpsertStatement > In method new org.apache.phoenix.parse.UpsertStatement(NamedTableNode, HintNode, List, List, SelectStatement, int, Map, List, UpsertStatement$OnDuplicateKeyType, boolean) > Field org.apache.phoenix.parse.UpsertStatement.onDupKeyPairs > Local variable named onDupKeyPairs > At UpsertStatement.java:[line 51] and this: > new org.apache.phoenix.parse.UpsertStatement(NamedTableNode, HintNode, List, List, SelectStatement, int, Map, List, UpsertStatement$OnDuplicateKeyType, boolean) may expose internal representation by storing an externally mutable object into UpsertStatement.values > -- > | Bug type EI_EXPOSE_REP2 (click for details)In class org.apache.phoenix.parse.UpsertStatementIn method new org.apache.phoenix.parse.UpsertStatement(NamedTableNode, HintNode, List, List, SelectStatement, int, Map, List, UpsertStatement$OnDuplicateKeyType, boolean)Field org.apache.phoenix.parse.UpsertStatement.valuesLocal variable named valuesAt UpsertStatement.java:[line 48] > > new org.apache.phoenix.parse.UpsertStatement(NamedTableNode, HintNode, List, List, SelectStatement, int, Map, List, UpsertStatement$OnDuplicateKeyType, boolean) may expose internal representation by storing an externally mutable object into UpsertStatement.values > [Bug type EI_EXPOSE_REP2 (click for details)](https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2226/10/artifact/yetus-general-check/output/new-spotbugs-phoenix-core-client.html#EI_EXPOSE_REP2) > In class org.apache.phoenix.parse.UpsertStatement > In method new org.apache.phoenix.parse.UpsertStatement(NamedTableNode, HintNode, List, List, SelectStatement, int, Map, List, UpsertStatement$OnDuplicateKeyType, boolean) > Field org.apache.phoenix.parse.UpsertStatement.values > Local variable named values > At UpsertStatement.java:[line 48] are also existing but I would leave them for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
