[
https://issues.apache.org/jira/browse/PHOENIX-7693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016770#comment-18016770
]
ASF GitHub Bot commented on PHOENIX-7693:
-----------------------------------------
stoty commented on code in PR #14:
URL: https://github.com/apache/phoenix-thirdparty/pull/14#discussion_r2307281766
##########
phoenix-shaded-protobuf/pom.xml:
##########
@@ -0,0 +1,86 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.phoenix.thirdparty</groupId>
+ <artifactId>phoenix-thirdparty</artifactId>
+ <version>2.1.1-SNAPSHOT</version>
+ </parent>
+ <artifactId>phoenix-shaded-protobuf</artifactId>
+ <name>Apache Phoenix Relocated (Shaded) Protobuf-Java</name>
+ <description>
Review Comment:
Description is enough
> Add shaded protobuf module to phoenix-thirdparty
> ------------------------------------------------
>
> Key: PHOENIX-7693
> URL: https://issues.apache.org/jira/browse/PHOENIX-7693
> Project: Phoenix
> Issue Type: Improvement
> Components: phoenix
> Reporter: Norbert Mészáros
> Assignee: Norbert Mészáros
> Priority: Major
> Labels: selected-for-development
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
