kadirozde commented on code in PR #2289:
URL: https://github.com/apache/phoenix/pull/2289#discussion_r2361550702


##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java:
##########
@@ -702,6 +708,10 @@ public boolean next(List<Cell> resultsToReturn, 
ScannerContext scannerContext)
           } while (
             hasMore && (EnvironmentEdgeManager.currentTimeMillis() - 
startTime) < pageSizeMs

Review Comment:
   We need to add here and to every other loop 
ScannerContextUtil.checkTimeLimit(scannerContext). This is to make sure that 
when a lower Phoenix region scanner requests to return immediately, the all the 
region scanners above that break their loop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to