stoty commented on code in PR #2291:
URL: https://github.com/apache/phoenix/pull/2291#discussion_r2556541419
##########
pom.xml:
##########
@@ -54,6 +55,12 @@
<module>phoenix-pherf</module>
<module>phoenix-tracing-webapp</module>
<!-- shaded artifact and assembly modules are added in shade-and-assembly
profile -->
+ <module>phoenix-client-parent</module>
+ <module>phoenix-client-parent/phoenix-client-embedded</module>
+ <module>phoenix-client-parent/phoenix-client-lite</module>
+ <module>phoenix-server</module>
+ <module>phoenix-mapreduce-byo-shaded-hbase</module>
+ <module>phoenix-assembly</module>
Review Comment:
These shouldn't be listed here.
Adding these here will disable the build optimizations that enable quicker
builds by skipping the shading steps.
##########
pom.xml:
##########
@@ -54,6 +55,12 @@
<module>phoenix-pherf</module>
<module>phoenix-tracing-webapp</module>
<!-- shaded artifact and assembly modules are added in shade-and-assembly
profile -->
+ <module>phoenix-client-parent</module>
+ <module>phoenix-client-parent/phoenix-client-embedded</module>
+ <module>phoenix-client-parent/phoenix-client-lite</module>
+ <module>phoenix-server</module>
+ <module>phoenix-mapreduce-byo-shaded-hbase</module>
+ <module>phoenix-assembly</module>
Review Comment:
See the comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
