richardantal commented on PR #2222: URL: https://github.com/apache/phoenix/pull/2222#issuecomment-3870710032
> It's been long time, sorry i could not take another round of the review. It seemed good in the past. The only concern is, i hope UpsertCompiler does not break any existing UPSERT functionalities. UpsertCompiler should not break any existing UPSERT functionalities. With this change we just accept a list of the already supported expressions. Test results are also looking good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
