virajjasani commented on code in PR #2401:
URL: https://github.com/apache/phoenix/pull/2401#discussion_r3082452042
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsExtendedIT.java:
##########
@@ -167,6 +182,9 @@ public void run() {
t2.start();
doneSignal.await(60, TimeUnit.SECONDS);
+ if (eventual) {
+ Thread.sleep(35000);
Review Comment:
> Using sleep with large times is going to make tests slow (and flaky but I
can guess we cannot do anything about that in this case). Since we are adding
multiple new tests which are going to need their own mini cluster, maybe we can
have waitFor(predicate, timeout) kind of polling instead to atleast let the
test make progress as soon as it can.
I have added such polling in other set of concurrent mutations extended
index IT tests, but here I could not add because this test also needs to be
used by synchronous index, so we want to keep the changes to the original tests
as less as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
