virajjasani commented on code in PR #2428:
URL: https://github.com/apache/phoenix/pull/2428#discussion_r3191291001
##########
phoenix-core/src/test/java/org/apache/phoenix/query/QueryPlanTest.java:
##########
@@ -213,6 +221,10 @@ public void testTenantSpecificConnWithLimit() throws
Exception {
QueryUtil.getExplainPlan(rs));
}
+ // V2 limitation: DESC timestamp compound byte layout isn't yet decodable by
the
+ // ExplainTable splitter (the schema iterator reports mismatched widths for
+ // DESC-inverted timestamp columns).
+ @org.junit.Ignore
Review Comment:
Is this breaking change with V2?
##########
phoenix-core/src/test/java/org/apache/phoenix/compile/WhereCompilerTest.java:
##########
@@ -427,16 +444,13 @@ public void testRowKeyFilter() throws SQLException {
Scan scan = plan.getContext().getScan();
Filter filter = scan.getFilter();
- assertEquals(
- new RowKeyComparisonFilter(
- constantComparison(CompareOperator.EQUAL,
- new SubstrFunction(Arrays.<Expression> asList(
- new RowKeyColumnExpression(ENTITY_ID,
- new RowKeyValueAccessor(ATABLE.getPKColumns(), 1)),
- LiteralExpression.newConstant(1),
LiteralExpression.newConstant(3))),
- keyPrefix),
- QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES),
- filter);
Review Comment:
If we can't assert this, is it not a regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
