kadirozde commented on PR #2428: URL: https://github.com/apache/phoenix/pull/2428#issuecomment-4391459212
> Switching to V2 mode is significant design change. Making that switch by default on 5.4.0 release is something we will have to take it to `dev@phoenix` for consensus. We can only switch to V2 mode smoothly if we know for certain that the V2 mode is 100% compatible with V1. For instance, any phoenix downstream service that relies on explain plan outputs from phoenix cannot expect breaking changes, unless the breaking changes are fixing data integrity issues. > > WhereOptimizer test changes seem quite complex to understand. How can we make all tests pass for both V1 and V2 where optimizer if we need lots of assert changes? > > Also, I see some tests ignored and some comments like the one with this review that states V2 limitations with some explain plan output. Can we list down all breaking and incompatible changes? We anyways have limited test coverage in where optimizer. I addressed all your concerns in this commit [d903f1e](https://github.com/apache/phoenix/pull/2428/commits/d903f1e87bfdb8e92d6820837c2ce333168b464a). Please note that the tests are updated only when V2's results is different but equivalent or better. In that case, these tests have different expected results for V1 and V2. The full test suite passes for both V1 and V2. Please note V1 code path will be depreciated and removed in future. That is why V2 is the new default. V1 is preserved to allow rollback when needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
