xavifeds8 opened a new pull request, #2480:
URL: https://github.com/apache/phoenix/pull/2480
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://phoenix.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
PHOENIX-XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes, and
prefix it with the JIRA id, e.g. 'PHOENIX-XXXX Your PR title ...'.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Added a ScanUtil.hasDynamicColumns(table) check in
WhereCompiler.setScanFilter() so that when the WHERE clause references multiple
columns and the table has dynamic columns, Phoenix falls back to
MultiCQKeyValueComparisonFilter (HashMap-based, raw byte comparison) instead of
MultiEncodedCQKeyValueComparisonFilter (array-based, expects encoded integer
qualifiers).
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When a table uses column encoding (the default) and the WHERE clause filters
on multiple dynamic columns, Phoenix selects
MultiEncodedCQKeyValueComparisonFilter. This filter calls
encodingScheme.decode() on each column qualifier, expecting a 2-4 byte encoded
integer.
Dynamic columns use the actual column name as the qualifier (e.g.,
"POPULATION" = 10 bytes), causing InvalidQualifierBytesException: Expected
length: 2. Actual: 10.
Single dynamic column in WHERE works fine because
SingleCQKeyValueComparisonFilter uses raw byte comparison. The workaround was
COLUMN_ENCODED_BYTES=NONE on table creation, which defeats the purpose of
encoding.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Phoenix versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Queries with multiple dynamic columns in the WHERE clause now work
correctly on tables with column encoding enabled (the default). Previously
these queries threw InvalidQualifierBytesException. No workaround
(COLUMN_ENCODED_BYTES=NONE) is needed anymore
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
5 new unit tests in WhereCompilerTest verifying correct filter selection:
1. Single dynamic column → SingleCQKeyValueComparisonFilter
2. Multiple dynamic columns → MultiCQKeyValueComparisonFilter (not Encoded)
3. Multiple schema columns → MultiEncodedCQKeyValueComparisonFilter (no
regression)
4. Non-encoded table → MultiCQKeyValueComparisonFilter
5. Single schema column → SingleCQKeyValueComparisonFilter
1 new integration test in DynamicColumnIT covering 7 scenarios:
1. No dynamic columns (baseline)
2. 1 dynamic column in WHERE
3. 2 dynamic columns in WHERE
4. 3 dynamic columns in WHERE
5. 1 schema + 2 dynamic (mixed)
6. 2 dynamic + 1 schema (mixed)
7. Dynamic columns compared to each other
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Yes. This patch was co-authored with Claude Code opus-4.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
