tkhurana opened a new pull request, #2484:
URL: https://github.com/apache/phoenix/pull/2484

   ## Summary
   - The static `ReplicationLogGroup.INSTANCES` cache was keyed by HA group 
name only, which is insufficient when a single JVM hosts multiple `ServerName`s 
(e.g. integration tests with multiple mini-cluster RegionServers in one 
process). Two RegionServers sharing the same HA group would collide on the same 
cache entry and one would silently get the other's `ReplicationLogGroup`.
   - This change keys the cache by `serverName + "|" + haGroupName` via a small 
`instanceKey(...)` helper, applied to both `get(...)` overloads and `close()`.
   
   ## Test plan
   - [ ] `mvn test -pl phoenix-core -Dtest=ReplicationLogGroupTest`
   - [ ] Run HA integration tests that bring up multiple RegionServers in the 
same JVM and verify each RS gets its own `ReplicationLogGroup` per HA group.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to