virajjasani commented on code in PR #2493:
URL: https://github.com/apache/phoenix/pull/2493#discussion_r3352754477
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/CDCGlobalIndexRegionScanner.java:
##########
@@ -123,21 +128,60 @@ protected Scan prepareDataTableScan(Collection<byte[]>
dataRowKeys) throws IOExc
) {
return null;
}
- // TODO: Get Timerange from the start row and end row of the index scan
object
- // and set it in the datatable scan object.
- // if (scan.getStartRow().length == 8) {
- // startTimeRange = PLong.INSTANCE.getCodec().decodeLong(
- // scan.getStartRow(), 0, SortOrder.getDefault());
- // }
- // if (scan.getStopRow().length == 8) {
- // stopTimeRange = PLong.INSTANCE.getCodec().decodeLong(
- // scan.getStopRow(), 0, SortOrder.getDefault());
- // }
Scan dataScan = prepareDataTableScan(dataRowKeys, true);
if (dataScan == null) {
return null;
}
- return CDCUtil.setupScanForCDC(dataScan);
+ CDCUtil.setupScanForCDC(dataScan);
+ Map<ImmutableBytesPtr, long[]> timestampMap =
buildDataRowTimestampMap(dataRowKeys);
Review Comment:
It is possible but it is far bigger refactor, worth doing as separate PR
because this PR is already too big. However, dataRowKeys are already available
so generating map would not be that time consuming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
