Copilot commented on code in PR #2524:
URL: https://github.com/apache/phoenix/pull/2524#discussion_r3406249551
##########
phoenix-core-client/src/main/java/org/apache/phoenix/compile/ExplainPlanAttributes.java:
##########
@@ -200,8 +209,9 @@ private ExplainPlanAttributes() {
public ExplainPlanAttributes(String tenantId, String viewName, String
viewBaseName,
String cdcScopes, String txnProvider, List<String> rewrites, Long
estimatedRows,
- Long estimatedSizeInBytes, Long estimateInfoTs, String
abstractExplainPlan, Hint hint,
- String explainScanType, Consistency consistency, String tableName, String
keyRanges,
+ Long estimatedSizeInBytes, Long estimateInfoTs, String abstractExplainPlan,
+ OnDuplicateKeyType onDuplicateKeyAction, List<String> serverUpdateSet,
boolean returningRow,
+ Hint hint, String explainScanType, Consistency consistency, String
tableName, String keyRanges,
Review Comment:
The public ExplainPlanAttributes constructor signature was changed by
inserting new parameters (onDuplicateKeyAction/serverUpdateSet/returningRow).
Since this is a public API in phoenix-core-client, removing the previous
signature is source/binary incompatible for any downstream callers that
instantiate ExplainPlanAttributes directly. Consider restoring the previous
constructor as an overload (deprecated if desired) that delegates to this new
constructor with default mutation values.
##########
phoenix-core-client/src/main/java/org/apache/phoenix/compile/ExplainPlanAttributes.java:
##########
@@ -752,6 +787,22 @@ public ExplainPlanAttributesBuilder
setAbstractExplainPlan(String abstractExplai
return this;
}
+ public ExplainPlanAttributesBuilder
+ setOnDuplicateKeyAction(OnDuplicateKeyType onDuplicateKeyAction) {
+ this.onDuplicateKeyAction = onDuplicateKeyAction;
Review Comment:
The setOnDuplicateKeyAction() builder method signature is split across two
lines even though it fits within the project's 100-character limit, unlike the
surrounding builder setters. Keeping it on one line improves readability and
consistency in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
