apurtell opened a new pull request, #2529: URL: https://github.com/apache/phoenix/pull/2529
Consolidate the rewrite pass entry points. Add `forRewrite()` on `StatementContext`, carrying rewrite breadcrumbs across the early rewrite pass at four call sites (`PhoenixStatement.ExecutableSelectStatement.compilePlan`, `DeleteCompiler.compile`, `UpsertCompiler.compile`, and `QueryCompiler.compileSubquery`). The bespoke `BindManager` and `FromCompiler` additions in `PhoenixStatement` and `DeleteCompiler` go away. Drops the legacy single argument rewriter overloads `SubselectRewriter.flatten(SelectStatement, PhoenixConnection)` and `SubqueryRewriter.transform(SelectStatement, ColumnResolver, PhoenixConnection)` plus the matching 3-arg `new SubqueryRewriter(...)` constructor. The four legacy overloads are deleted, and the trivial forwarding layer goes with them. No behavior change. EXPLAIN text and JSON output are unchanged. Co-authored-by: Claude Opus 4.8[1m] <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
