ritegarg commented on PR #2518: URL: https://github.com/apache/phoenix/pull/2518#issuecomment-4710221319
> Approved. I did the review myself, but did have the robots help with considering TLA model updates after this goes in. (I'll have some fun there.) > > Then I asked for suggestions on improving test coverage because the current coverage seems a bit weak. These were the suggestions, fyi > > 1. Drive (ANIS, DS) -> (S, AIS) through the real ZK + FailoverManagementListener path in something like FailoverPhoenixConnectionIT or HAGroupStoreManagerIT, and assert both clusters converge to (S, AIS). The current unit test only pins the transition table. > 2. Nit in HAGroupStoreRecordTest: Add an assertFalse(DEGRADED_STANDBY.isTransitionAllowed(SOMETHING_NOT_IN_SET)) to lock down the allowed set. 1. It will not work with this change, @Himanshu-g81 will work on [PHOENIX-7920](https://issues.apache.org/jira/browse/PHOENIX-7920) and we can add a test then. 2. I have added that test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
