apurtell opened a new pull request, #2537: URL: https://github.com/apache/phoenix/pull/2537
Address review feedback for EXPLAIN improvements - `StatementContext.adoptRewriteState` shares mutable collections by reference. Have `adoptRewriteState` and the copy constructor allocate fresh collections. - In `ExplainPlanAttributes`, `serverMergeColumns`, `subPlans`, and `regionLocations` are the only fields not wrapped with `Collections.unmodifiableX(...)`. Callers can mutate after build, silently corrupting EXPLAIN JSON. Wrap these three fields the same way the others are wrapped. - Remove an unwanted catch of `Exception` in `ExplainTable`. Remove now unused SLF4J imports. - PHOENIX-7928 changed 14 index rule assertions to a simple substring match on "matches" because the index type is a functional index. Restore and improve the affected assertions. Co-authored-by: Claude Opus 4.8[1m] <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
