palashc commented on code in PR #9:
URL: https://github.com/apache/phoenix-adapters/pull/9#discussion_r3463250517
##########
phoenix-ddb-rest/src/main/java/org/apache/phoenix/ddb/service/utils/DQLUtils.java:
##########
@@ -187,6 +187,10 @@ public static void addFilterCondition(boolean isQuery,
StringBuilder queryBuilde
*/
public static void setKeyValueOnStatement(PreparedStatement stmt, int
index,
Map<String, Object> attrVal, boolean isBeginsWith) throws
SQLException {
+ if (attrVal == null) {
+ throw new ValidationException(
+ "Value provided in ExpressionAttributeValues is missing or
invalid");
Review Comment:
nit: can we change the message to "An expression attribute value used is not
defined." - this is slightly more inline with what ddb throws
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
