[ 
https://issues.apache.org/jira/browse/PHOENIX-7939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18092446#comment-18092446
 ] 

Andrew Kyle Purtell commented on PHOENIX-7939:
----------------------------------------------

Although this is an independent fix suggestion from PHOENIX-7820, PHOENIX-7820 
will solve it, so I will resolve this one as a duplicate. Normally one would 
not expect to be taking two snapshots of a table within a single second. 

> UpgradeUtil.getSysTableSnapshotName should use millisecond resolution
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-7939
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7939
>             Project: Phoenix
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Andrew Kyle Purtell
>            Priority: Major
>
> {{UpgradeUtil.getSysTableSnapshotName(long, String)}} formats its snapshot id 
> suffix with {{SimpleDateFormat("yyyyMMddHHmmss")}}, which has the minimum 
> resolution of only one second. During Phoenix's {{upgradeSystemTables}} path 
> and especially under {{BackwardCompatibilityIT}}'s parameterized replay of 
> old-client upgrades, the same {{SYSTEM.LOG}} snapshot can be requested twice 
> inside the same second. The second request produces an identical snapshot id, 
> HBase's {{SnapshotManager.prepareToTakeSnapshot}} sees an in-flight snapshot 
> with the very same id, and rejects it with {{SnapshotCreationException: 
> "already running another snapshot on the same table"}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to