richardantal commented on code in PR #2569:
URL: https://github.com/apache/phoenix/pull/2569#discussion_r3613244130
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -2052,8 +2053,8 @@ private TableDescriptor ensureTableCreated(byte[]
physicalTableName,
return null; // Indicate that no metadata was changed
}
- // Do not call modifyTable for SYSTEM tables
- if (tableType != PTableType.SYSTEM) {
+ // Do not call modifyTable for: SYSTEM tables or when CREATE IF NOT
EXISTS was used.
+ if (tableType != PTableType.SYSTEM && !createIfNotExists) {
Review Comment:
Couldn't we return earlier? When we realize that `tableExist` or similarly
to `modifyExistingMetaData`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
