tkhurana commented on code in PR #2576:
URL: https://github.com/apache/phoenix/pull/2576#discussion_r3640494712
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreClient.java:
##########
@@ -795,6 +804,7 @@ private void updateSystemTableHAGroupRecordSilently(String
haGroupName,
pstmt.executeUpdate();
conn.commit();
} catch (Exception e) {
+ metricsSource.incrementSystemTableSyncFailedCount();
Review Comment:
So this metric is only accounting for write failures but it is ignoring all
other failures which can happen before the call even reaches here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
