Himanshu-g81 commented on code in PR #2588:
URL: https://github.com/apache/phoenix/pull/2588#discussion_r3673365466
##########
phoenix-core-server/src/main/java/org/apache/phoenix/replication/ReplicationLogTracker.java:
##########
@@ -368,15 +368,16 @@ protected Optional<Path> markInProgress(final Path file) {
// Format: <ts>_<server>_<UUID>_<renameTs>.plog → extract prefix
(first 2 parts)
String[] parts = fileName.split("_");
String prefix = parts[0] + "_" + parts[1];
- newFileName =
- prefix + "_" + UUID.randomUUID() + "_" +
EnvironmentEdgeManager.currentTime() + ".plog";
+ newFileName = prefix + "_" + UUID.randomUUID() + "_" +
EnvironmentEdgeManager.currentTime()
Review Comment:
nit: can be a utility method and reused in the same file for in progress
files.
##########
phoenix-core-server/src/main/java/org/apache/phoenix/replication/ReplicationShardDirectoryManager.java:
##########
@@ -64,11 +64,14 @@ public class ReplicationShardDirectoryManager {
*/
public static final String SHARD_DIR_FORMAT = "%03d";
+ /** File extension for replication log files. */
+ public static final String LOG_FILE_EXTENSION = ".plog";
Review Comment:
Good to replace all the usages? Example:
https://github.com/apache/phoenix/blob/91db1394c69803c57a645bb2ca199dc1bf84d0c6/phoenix-core-server/src/main/java/org/apache/phoenix/replication/tool/LogFileAnalyzer.java#L208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
