tkhurana commented on code in PR #2574:
URL: https://github.com/apache/phoenix/pull/2574#discussion_r3786335785
##########
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -794,18 +808,16 @@ private void
addOnDupMutationsToBatch(MiniBatchOperationInProgress<Mutation> min
*/
private void
updateMutationsForConditionalTTL(MiniBatchOperationInProgress<Mutation>
miniBatchOp,
BatchMutateContext context) throws IOException {
- // If TTL is not strict, skip conditional TTL processing
- if (!context.isStrictTTLForInternalScan) {
+ if (!context.isConditionalTTL()) {
Review Comment:
Are we mixing the two concepts here conditional ttl and literal ttl and
strict vs non-strict ttl. These are independent properties and all 4
combinations are possible and permitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
