Himanshu-g81 commented on code in PR #2607:
URL: https://github.com/apache/phoenix/pull/2607#discussion_r3924365064
##########
phoenix-core-server/src/main/java/org/apache/phoenix/replication/metrics/MetricsReplicationLogDiscovery.java:
##########
@@ -62,6 +65,14 @@ public interface MetricsReplicationLogDiscovery extends
BaseSource {
*/
void updateTimeToProcessInProgressFiles(long timeMs);
+ /**
+ * Increments the counter for rounds whose new-file processing time exceeded
the round time. This
+ * counter lives on the shared discovery base, so it is emitted by both the
forwarder-side and
+ * replay-side discovery sources; a rising rate signals that that side's
new-file processing is
+ * falling behind the cadence at which new rounds become eligible.
Review Comment:
It's intentional as both replay and forwarder. Updated the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
