apurtell commented on PR #2428: URL: https://github.com/apache/phoenix/pull/2428#issuecomment-6100120618
@kadirozde I addressed your review comments on 05fed39. While performing the work I enabled a workflow that took the feedback of adversarial reviewers into consideration in a loop. This process took 29 findings developed over 9 rounds of review as input and clustered them into 4 root causes, producing 4 additional commits, which were then themselves subjected to a round of adversarial review. The workflow also classified whether a case an adversarial review claimed could be encountered in any realistic query shapes. There were additional findings considered rare or unlikely that were not addressed, in order for this process to converge. Additional test cases have been added to exercise the cases found during adversarial review. Those new test cases and all existing test cases all pass. As such these four commits ship a converged hardening of the integration of the box algebra on top of the existing complexity of Phoenix's key structure (where it accumulated this complexity over time for supporting ascending and descending sort orders, variable length fields, and nullable fields). I hope this isn't too much change on top of what has already been delivered here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
