[
https://issues.apache.org/jira/browse/PLC4X-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098147#comment-17098147
]
César García commented on PLC4X-159:
------------------------------------
Sorry Chris,
The problem is fixed in 0.6.0,
I fixed in my fork, but I see the fix here:
[https://github.com/apache/plc4x/blob/release/0.6.0/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/protocol/SingleItemToSingleRequestProtocol.java]
Best regards,
> modbus: Future which writes data correctly in modbus does not return
> --------------------------------------------------------------------
>
> Key: PLC4X-159
> URL: https://issues.apache.org/jira/browse/PLC4X-159
> Project: Apache PLC4X
> Issue Type: Bug
> Components: Driver-Modbus
> Reporter: Alvaro del Castillo
> Assignee: Christofer Dutz
> Priority: Major
> Fix For: 0.7.0
>
> Attachments: Screenshot from 2019-12-07 09-44-45.png
>
>
> When writing data registers in modbus, the data is written correctly but the
> Future which does it does not return. The hack is just to not wait for the
> Future because you don't need the results. Just that the data is written. But
> if there are some error during the writing you don't know it. And probably
> the resources are not freed correctly.
> Some sample code:
> {code:java}
> PlcWriteRequest writeRequest = connection.writeRequestBuilder()
> .addItem(registerName, "register:" + offset + "[" + size + "]",
> writeRegister)
> .build();
> writeRequest.execute().whenComplete((writeResponse, error) -> {
> assertNotNull(writeResponse);
> });
> {code}
> The whenComplete is never called. I have follow the code and the "decode"
> method is called, so it is when processing the response from the modbus slave
> where the problem is.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
